feat: add support for NodeJS Azure Functions project type#174
Open
martindandanell wants to merge 1 commit intosyncable-dev:mainfrom
Open
feat: add support for NodeJS Azure Functions project type#174martindandanell wants to merge 1 commit intosyncable-dev:mainfrom
martindandanell wants to merge 1 commit intosyncable-dev:mainfrom
Conversation
| ], | ||
| is_primary_indicator: true, | ||
| alternative_names: vec!["azure-functions".to_string()], | ||
| file_indicators: vec!["host.json".to_string(), "local.settings.json".to_string(), "function.json".to_string()], |
There was a problem hiding this comment.
At least for Python, local.settings.json and function.json aren't necessarily present in function apps with the v2 programming model. host.json should always be there, though.
In the case of container-based function apps, you could have a Dockerfile, so not sure it makes sense to add that as an indicator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
FunctionAppproject typenextjs_does_not_detect_with_application_folderas an example)Implementation details
FunctionAppproject type and the category toService(MS defines an Azure Functions app as a "Serverless computing service")Example output
Remarks
cargo testresults in 4 failing tests that does not appear to be caused by my changes (see output below)cargo auditcommand does not exist when following the CONTRIBUTING guideline to setup the project tools (Disclaimer: I'm not used to working with Rust)Failing tests output